NGWPC NWM PI-3 Formulation Selection Delivery 2025-11-21#7
Open
cmaynard-ngwpc wants to merge 29 commits intoNOAA-OWP:mainfrom
Open
NGWPC NWM PI-3 Formulation Selection Delivery 2025-11-21#7cmaynard-ngwpc wants to merge 29 commits intoNOAA-OWP:mainfrom
cmaynard-ngwpc wants to merge 29 commits intoNOAA-OWP:mainfrom
Conversation
Merge release-candidate into development for release 1.2.0-rc1 See merge request NGWPC/nwm-ngen/ngen-fcst!32
Merge main into development for release 1.2.0 See merge request NGWPC/nwm-ngen/ngen-fcst!35
…elopment' updates to allow csv forcing See merge request NGWPC/nwm-ngen/ngen-fcst!29
Delete version.txt See merge request NGWPC/nwm-ngen/ngen-fcst!36
…elopment' updates to allow csv forcing See merge request NGWPC/nwm-ngen/ngen-fcst!29
Pass in path to forcing files instead of netcdf file See merge request NGWPC/nwm-ngen/ngen-fcst!37
Update script See merge request NGWPC/nwm-ngen/ngen-fcst!38
Migrate CI/CD to Github
fix release builds and remove unnecessary docker commands
Forecast validation multiple calls
Add ngen_results_dir to forecast
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance the forecast manager workflow, including adding ngen_results_dir, supporting separate cold start and forecast calls, and updating nwm-fcst-mgr for compatibility with the new workflow. Logging and error handling were improved, and scripts were updated to pass forcing file paths and support CSV forcing. Docker and CI/CD files were refined to fix release builds, manage dependencies via virtual environments, and streamline repository usage. Documentation and README updates reflect the new argument structure and workflow changes, and version.txt was removed.